Re: [PATCH 1/4] ASoC: rockchip: add rockchip machine driver
From: Mark Brown
Date: Wed May 13 2015 - 12:43:25 EST
On Wed, May 13, 2015 at 09:23:01PM +0800, zhengxing wrote:
> On 2015å05æ13æ 03:22, Mark Brown wrote:
> >Is it not possible to extend simple card to handle your use cases?
> >Given the very generic naming and the fact that things like jack
> >detection and so on should depend on the CODEC and board usually rather
> >than on the SoC it doesn't sound like this is Rockchip specific.
> >This also looks like you're reimplementing some device model enumeration
> >stuff which probably shouldn't be happening but let's understand the
> >problem you're trying to solve here before going too far into the code.
> Because we are trying to bring rt5650 in the project, so we intend to
> describe supported codecs with DTS via only a rockchip machine driver file,
> others remain pre-implement(like max98090 / rt5645 that vendor machine
I don't undertand what you're saying here, sorry - why is this not just
a case of writing multiple machine drivers?
> I communicated with Dylan, and he told me that the jack detection is an
> issue in the simple-card, and suggested we are better to send them at
But what are these issues?
Description: Digital signature