[PATCH] uio: don't free irq that was not requested

From: Stephen Hemminger
Date: Thu May 14 2015 - 12:19:23 EST


UIO base driver should only free_irq that it has requested.
UIO supports drivers without interrupts (irq == 0) or custom handlers.

This fixes warnings like:

WARNING: CPU: 1 PID: 5478 at kernel/irq/manage.c:1244 __free_irq+0xa9/0x1e0()
Trying to free already-free IRQ 0

Signed-off-by: Stephen Hemminger <stephen@xxxxxxxxxxxxxxxxxx>

--- a/drivers/uio/uio.c 2015-05-14 09:04:54.677283462 -0700
+++ b/drivers/uio/uio.c 2015-05-14 09:09:28.170547587 -0700
@@ -879,7 +879,8 @@ void uio_unregister_device(struct uio_in

uio_dev_del_attributes(idev);

- free_irq(idev->info->irq, idev);
+ if (info->irq && info->irq != UIO_IRQ_CUSTOM)
+ free_irq(info->irq, idev);

device_destroy(&uio_class, MKDEV(uio_major, idev->minor));


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/