Re: [PATCH v2] leds: fix brightness changing when software blinking is active

[Jacek Anaszewski]

On 05/15/2015 04:11 PM, Stas Sergeev wrote:
> 15.05.2015 17:09, Jacek Anaszewski ÐÐÑÐÑ:
> > On 05/15/2015 10:12 AM, Jacek Anaszewski wrote:
> > > Hi Stas,
> > >
> > > On 05/14/2015 05:24 PM, Stas Sergeev wrote:
> > > > The following sequence:
> > > > echo timer >/sys/class/leds/<name>/trigger
> > > > echo 1 >/sys/class/leds/<name>/brightness
> > > > should change the ON brightness for blinking.
> > > > The function led_set_brightness() was mistakenly initiating the
> > > > delayed blink stop procedure, which resulted in no blinking with
> > > > the timer trigger still active.
> > > >
> > > > This patch fixes the problem by changing led_set_brightness()
> > > > to not initiate the delayed blink stop when brightness is not 0.
> >
> > This commit message is not valid for this version of the patch.
> Why do you think so?
> ---
> -		schedule_work(&led_cdev->set_brightness_work);
> +		if (brightness == LED_OFF)
> +			schedule_work(&led_cdev->set_brightness_work);
> ---
>
> LED_OFF is a 0 define.

You're right, I was just looking at the issue from different
perspective.

--
Best Regards,
Jacek Anaszewski
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/