Re: [PATCHv5 03/28] memcg: adjust to support new THP refcounting

From: Dave Hansen
Date: Fri May 15 2015 - 10:57:45 EST


On 05/15/2015 04:18 AM, Kirill A. Shutemov wrote:
>> > But same question about whether it should be using hpage_nr_pages() instead
>> > of a constant.
> No. Compiler woundn't be able to optimize HPAGE_PMD_NR away for THP=n,
> since compound value cross compilation unit barrier.

What code are you talking about here, specifically? This?

static inline int hpage_nr_pages(struct page *page)
{
if (unlikely(PageTransHuge(page)))
return HPAGE_PMD_NR;
return 1;
}

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/