Re: [PATCH] staging: rtl8712: Use ether_addr_copy() instead of memcpy()

From: Greg Kroah-Hartman
Date: Sun May 17 2015 - 19:27:27 EST


On Mon, May 18, 2015 at 02:27:01AM +0530, Jagan Teki wrote:
> This patch fixes to use ether_addr_copy() instead of memcpy()
>
> Encounter this by applying checkpatch.pl against this file:
> WARNING: Prefer ether_addr_copy() over memcpy()
> if the Ethernet addresses are __aligned(2)
>
> Signed-off-by: Jagan Teki <jteki@xxxxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: Larry Finger <Larry.Finger@xxxxxxxxxxxx>
> Cc: Florian Schilhabel <florian.c.schilhabel@xxxxxxxxxxxxxx>
> ---
> drivers/staging/rtl8712/os_intfs.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)

You need to prove that the addresses are aligned, please do so in the
changelog entry.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/