Re: [PATCH 1/2] ARM: simplify timer initialisation and remove arm_timer.h inclusion

From: Sudeep Holla
Date: Mon May 18 2015 - 06:43:37 EST


Hi Russell,

On 18/05/15 11:40, Russell King - ARM Linux wrote:
On Thu, Apr 30, 2015 at 09:09:47AM -0500, Rob Herring wrote:
On Thu, Apr 30, 2015 at 5:44 AM, Sudeep Holla <sudeep.holla@xxxxxxx> wrote:
The header asm/hardware/arm_timer.h is included in various machine
specific files to access TIMER_CTRL and initialise to a known state.
However that's not required as the clock{source,event} driver timer-sp
initialises all the timer being used.

I believe the idea is not to initialize the timers being used, but the
ones not being used and perhaps left running by the bootloader. Cases
where the interrupt is shared could cause a problem.

Exactly. IMHO this code needs to stay.


Thanks for confirming.

Regards,
Sudeep
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/