Re: [PATCH v2 03/10] clk: sunxi: Let divs clocks read the base factor clock name from devicetree

[Chen-Yu Tsai]

On Mon, May 18, 2015 at 5:15 PM, Jens Kuske <jenskuske@xxxxxxxxx> wrote:
> Hi,
>
> On 05/16/15 04:10, Chen-Yu Tsai wrote:
>> 2015å5æ16æ äå12:39æ "Jens Kuske" <jenskuske@xxxxxxxxx>åéï
> [..]
>>> @@ -1141,6 +1133,7 @@ static void __init sunxi_divs_clk_setup(struct
>> device_node *node,
>>>         struct clk_gate *gate = NULL;
>>>         struct clk_fixed_factor *fix_factor;
>>>         struct clk_divider *divider;
>>> +       struct factors_data factors = *data->factors;
>
> Isn't this a copy?

You're right. Sorry for the noise.

>
>>>         void __iomem *reg;
>>>         int ndivs = SUNXI_DIVS_MAX_QTY, i = 0;
>>>         int flags, clkflags;
>>> @@ -1149,8 +1142,17 @@ static void __init sunxi_divs_clk_setup(struct
>> device_node *node,
>>>         if (data->ndivs)
>>>                 ndivs = data->ndivs;
>>>
>>> +       /* Try to find a name for base factor clock */
>>> +       for (i = 0; i < ndivs; i++) {
>>> +               if (data->div[i].self) {
>>> +                       of_property_read_string_index(node,
>> "clock-output-names",
>>> +                                                     i, &factors.name);
>>
>> Please excuse the bad formatting.
>> I'm at the airport without my laptop.
>>
>> This will not work. All the static factors_data structs are const.
>> You should make a copy of it, maybe on the stack,
>> update the .name field, and pass that to sunxi_factors_clk_setup().
>>
>
> If I didn't miss anything, or misunderstood what you want to copy, this
> should be working fine.
>
> Jens
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/