Re: [PATCH net-next] netfilter: Use correct return for seq_show functions
From: Pablo Neira Ayuso
Date: Mon May 18 2015 - 11:53:19 EST
On Tue, May 12, 2015 at 06:28:23PM -0700, Joe Perches wrote:
> Using seq_has_overflowed doesn't produce the right return value.
> Either 0 or -1 is, but 0 is much more common and works well when
> seq allocation retries.
>
> I believe this doesn't matter as the initial allocation is always
> sufficient, this is just a correctness patch.
>
> Miscellanea:
>
> o Don't use strlen, use *ptr to determine if a string
> should be emitted like all the other tests here
> o Delete unnecessary return statements
Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/