Re: [PATCH] Staging: rtl8192e: Timer setup using macro rather assignment

[Sudip Mukherjee]

On Mon, May 18, 2015 at 09:26:03AM -0700, Joe Perches wrote:
> On Mon, 2015-05-18 at 21:35 +0530, Sudip Mukherjee wrote:
> > On Mon, May 18, 2015 at 02:44:15PM +0000, DHANAPAL, GNANACHANDRAN (G.) wrote:
> > > setup_timer is used for timer parameter setup rather than direct
> > > assignment
> > > 
> > > Signed-off-by: Gnanachandran Dhanapal <gdhanapa@xxxxxxxxxxx>
> > 
> > your From: name and Signed-off-by: names are not matching. They should
> > be same.
> 
> If there's a specific "From: " in the _body_ of the email,
> that's true, but the sender email "From: " header and the
> Signed-off-by: line do not have to match.
But Greg usually rejects these patches where the sender "From:" header
and Signed-off-by: doesnot match. Just for example:

https://lkml.org/lkml/2014/11/25/924

regards
sudip

> 
> A "From: " line in the email body should only be used when
> the patch is from a different sender than the sign-off.
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/