Re: [RFC PATCH v3 19/37] bpf tools: Clear libelf and ELF parsing resrouce to finish opening

[Alexei Starovoitov]

On 5/17/15 3:56 AM, Wang Nan wrote:
> After all eBPF programs in an object file are loaded, related ELF
> information is useless. Close the object file and free those memory.
>
> Signed-off-by: Wang Nan <wangnan0@xxxxxxxxxx>
> ---
>   tools/lib/bpf/libbpf.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
> index ded96cb..9ed8cca 100644
> --- a/tools/lib/bpf/libbpf.c
> +++ b/tools/lib/bpf/libbpf.c
> @@ -687,8 +687,8 @@ struct bpf_object *bpf_open_object(const char *path)
>   	if (bpf_obj_validate(obj))
>   		goto out;
>
> +	bpf_obj_clear_elf(obj);
>   	return obj;
> -
>   out:
>   	bpf_close_object(obj);
>   	return NULL;

looks like a bug in some previous patch in the same set.
Should be squashed with that patch?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/