Re: [PATCH] Staging: unisys: fix function declaration format in visorchipset.c

[Wim de With]

On 18-5-2015 12:45, Jes Sorensen wrote:
> Wim de With <nauxuron@xxxxxxxxxxxxx> writes:
>> This is a patch that fixes the function declarations in
>> visorbus/visorchipset.c by removing newlines after the function return
>> type
> 
> This patch doesn't fix things, it makes things worse!
> 
> If you want to post patches to this, do it properly and check the output
> first.
> 
> NACK
> 
> Jes

But how is line breaking in function headers supposed to be done? The
coding style documentation specifically state the following:
"Descendants are always substantially shorter than the parent and are
placed substantially to the right. The same applies to function headers
with a long argument list."

I really don't want to bother you with trivial patches, especially when
they are incorrect, but I am trying to learn something, so I hope you
will help me out.

Wim









--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/