Re: [PATCH 11/40] perf tools: Add a test case for thread comm handling

[Namhyung Kim]

On Mon, May 18, 2015 at 09:29:03PM +0200, Jiri Olsa wrote:
> On Mon, May 18, 2015 at 09:30:26AM +0900, Namhyung Kim wrote:
> 
> SNIP
> 
> > diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-test.c
> > index f42af98a5c16..372b6395a448 100644
> > --- a/tools/perf/tests/builtin-test.c
> > +++ b/tools/perf/tests/builtin-test.c
> > @@ -171,6 +171,10 @@ static struct test {
> >  		.func = test__kmod_path__parse,
> >  	},
> >  	{
> > +		.desc = "Test thread comm handling",
> > +		.func = test__thread_comm,
> > +	},
> > +	{
> >  		.func = NULL,
> >  	},
> >  };
> > diff --git a/tools/perf/tests/perf-targz-src-pkg b/tools/perf/tests/perf-targz-src-pkg
> > deleted file mode 100755
> > index 238aa3927c71..000000000000
> > --- a/tools/perf/tests/perf-targz-src-pkg
> > +++ /dev/null
> 
> you dont like this one? ;-)

Argh, I don't know how it's included in this patch.  Will remove :-/

Thanks,
Namhyung


> 
> jirka
> 
> > @@ -1,21 +0,0 @@
> > -#!/bin/sh
> > -# Test one of the main kernel Makefile targets to generate a perf sources tarball
> > -# suitable for build outside the full kernel sources.
> > -#
> > -# This is to test that the tools/perf/MANIFEST file lists all the files needed to
> > -# be in such tarball, which sometimes gets broken when we move files around,
> > -# like when we made some files that were in tools/perf/ available to other tools/
> > -# codebases by moving it to tools/include/, etc.
> > -
> > -PERF=$1
> > -cd ${PERF}/../..
> > -make perf-targz-src-pkg > /dev/null
> > -TARBALL=$(ls -rt perf-*.tar.gz)
> > -TMP_DEST=$(mktemp -d)
> > -tar xf ${TARBALL} -C $TMP_DEST
> > -rm -f ${TARBALL}
> > -cd - > /dev/null
> > -make -C $TMP_DEST/perf*/tools/perf > /dev/null 2>&1
> > -RC=$?
> > -rm -rf ${TMP_DEST}
> > -exit $RC
> 
> SNIP
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/