Re: [PATCH 13/40] perf tools: Convert dead thread list into rbtree

[Namhyung Kim]

On Mon, May 18, 2015 at 09:34:25PM +0200, Jiri Olsa wrote:
> On Mon, May 18, 2015 at 09:30:28AM +0900, Namhyung Kim wrote:
> 
> SNIP
> 
> > @@ -38,6 +39,7 @@ struct thread *thread__new(pid_t pid, pid_t tid)
> >  		thread->ppid = -1;
> >  		thread->cpu = -1;
> >  		INIT_LIST_HEAD(&thread->comm_list);
> > +		INIT_LIST_HEAD(&thread->tid_node);
> >  
> >  		if (unwind__prepare_access(thread) < 0)
> >  			goto err_thread;
> > @@ -54,7 +56,7 @@ struct thread *thread__new(pid_t pid, pid_t tid)
> >  
> >  		list_add(&comm->list, &thread->comm_list);
> >  		atomic_set(&thread->refcnt, 0);
> > -		INIT_LIST_HEAD(&thread->node);
> > +		INIT_LIST_HEAD(&thread->tid_node);
> 
> tid_node is initialized twice

Okay, will fix.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/