Re: [PATCH v3 1/2] Staging: comedi: fix line longer than 80 chars in cb_pcidas64.c

[Ian Abbott]

On 20/05/15 09:22, Sudip Mukherjee wrote:
> On Wed, May 20, 2015 at 09:24:18AM +0200, Amaury Denoyelle wrote:
> > Sudip Mukherjee <sudipm.mukherjee@xxxxxxxxx> wrote:
> >
> > > On Tue, May 19, 2015 at 07:57:49PM +0200, Amaury Denoyelle wrote:
> > > <snip>
> > > > @@ -1381,7 +1382,9 @@ static int set_ai_fifo_segment_length(struct comedi_device *dev,
> > > >   	return devpriv->ai_fifo_segment_length;
> > > >   }
> > > >
> > > > -/* adjusts the size of hardware fifo (which determines block size for dma xfers) */
> > > > +/*
> > > > + * adjusts the size of hardware fifo (which determines block size for dma xfers)
> > > > + */
> > > I did not understand this one. You are not breaking the comment into
> > > two lines, then why multiline style?
> > >
> > > >   	const struct pcidas64_board *thisboard = dev->board_ptr;
> > > > @@ -1588,7 +1591,9 @@ static inline void warn_external_queue(struct comedi_device *dev)
> > > >   		"Use internal AI channel queue (channels must be consecutive and use same range/aref)\n");
> > > >   }
> > > >
> > > > -/* Their i2c requires a huge delay on setting clock or data high for some reason */
> > > > +/*
> > > > + * their i2c requires a huge delay on setting clock or data high for some reason
> > > > + */
> > > same here.
> >
> > The single-line version of these comments are over 80 characters (just
> > because of the "*/" characters), so I had to split them over several
> > lines.
> yes, i noticed. its almost 84 char. but after applying your patch also
> it comes to 81.

Really?  I only see 80 characters.

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/