Re: [PATCH v7 1/5] random: Blocking API for accessing nonblocking_pool

[Stephan Mueller]

Am Donnerstag, 21. Mai 2015, 02:45:35 schrieb Herbert Xu:

Hi Herbert,

> On Wed, May 20, 2015 at 07:44:39PM +0200, Stephan Mueller wrote:
> > +	if (unlikely(nonblocking_pool.initialized == 0)) {
> > +		do {
> > +			rc = wait_event_interruptible(urandom_init_wait,
> > +						nonblocking_pool.initialized);
> > +		} while (rc == -ERESTARTSYS);
> 
> This is just a convoluted way of doing an uninterruptible sleep.
> Either make it uninterruptible or allow the function to return
> an error.

Sorry, I overlooked the availability of wait_event. I was looking for it 
initially, but missed it. I will fix it right away.

-- 
Ciao
Stephan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/