Re: [PATCH 5/7] x86/intel_rdt: Software Cache for IA32_PQR_MSR

From: Thomas Gleixner
Date: Wed May 20 2015 - 14:50:37 EST


On Wed, 20 May 2015, Vikas Shivappa wrote:
> On Fri, 15 May 2015, Thomas Gleixner wrote:
> > > -static DEFINE_PER_CPU(struct intel_cqm_state, cqm_state);
> > > +DEFINE_PER_CPU(struct intel_pqr_state, pqr_state);
> >
> > With CONFIG_PERF=n and CONFIG_CGROUP_RDT=y the linker will fail.
>
> copy from Makefile below -
> obj-$(CONFIG_CPU_SUP_INTEL) += perf_event_intel_rapl.o
> perf_event_intel_cqm.o
>
> should work with CONFIG_PERF_EVENTS=n and CGROUP_RDT=y ?

Groan. Did you try to compile it? Certainly not.

Simply because the whole section which contains perf_event* object
files is conditional on

ifdef CONFIG_PERF_EVENTS

I'm starting to get really grumpy and tired of your attitude.

Thanks,

tglx


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/