Aw: Re: [PATCH v1] ARM: dts: nitrogen6x: add CAN support

[Peter Seiderer]

Hello Fabio,

> Gesendet: Donnerstag, 21. Mai 2015 um 00:26 Uhr
> Von: "Fabio Estevam" <festevam@xxxxxxxxx>
> An: "Peter Seiderer" <ps.report@xxxxxxx>
> Cc: linux-kernel <linux-kernel@xxxxxxxxxxxxxxx>, "Mark Rutland" <mark.rutland@xxxxxxx>, "devicetree@xxxxxxxxxxxxxxx" <devicetree@xxxxxxxxxxxxxxx>, "Russell King" <linux@xxxxxxxxxxxxxxxx>, "Pawel Moll" <pawel.moll@xxxxxxx>, "Ian Campbell" <ijc+devicetree@xxxxxxxxxxxxxx>, "Rob Herring" <robh+dt@xxxxxxxxxx>, "Sascha Hauer" <kernel@xxxxxxxxxxxxxx>, "Kumar Gala" <galak@xxxxxxxxxxxxxx>, "Shawn Guo" <shawn.guo@xxxxxxxxxx>, "linux-arm-kernel@xxxxxxxxxxxxxxxxxxx" <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>
> Betreff: Re: [PATCH v1] ARM: dts: nitrogen6x: add CAN support
>
> On Wed, May 20, 2015 at 6:49 PM, Peter Seiderer <ps.report@xxxxxxx> wrote:
> 
> > +               pinctrl_can1_1: can1grp-1 {
> > +                       fsl,pins = <
> > +                               MX6QDL_PAD_KEY_COL2__FLEXCAN1_TX 0x80000000
> > +                               MX6QDL_PAD_KEY_ROW2__FLEXCAN1_RX 0x80000000
> 
> Better not to pass 0x80000000. Use the real PAD settings instead.
> 

Thanks for review, will fix it...

Regards,
Peter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/