Re: [PATCH v2 1/3] perf tools: Fix dso__data_read_offset() file opening
From: Arnaldo Carvalho de Melo
Date: Thu May 21 2015 - 10:49:44 EST
Em Thu, May 21, 2015 at 10:03:27AM +0300, Adrian Hunter escreveu:
> On 20/05/15 19:03, Namhyung Kim wrote:
> > When dso__data_read_offset/addr() is called without prior
> > dso__data_fd() (or other functions which call it internally), it
> > failed to open dso in data_file_size() since its binary type was not
> > identified.
> >
> > However calling dso__data_fd() in dso__data_read_offset() will hurt
> > performance as it grabs a global lock everytime. So factor out the
> > loop on the binary type in dso__data_fd(), and call it from both.
> >
> > Reported-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>
> > Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxxx>
>
> Acked-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>
Thanks, all applied.
- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/