Re: [PATCH] coresight-etm3x: Add Qualcomm PFT v1.1 peripheral ID

From: Ivan T. Ivanov
Date: Thu May 21 2015 - 11:24:34 EST



On Thu, 2015-05-21 at 08:10 -0600, Mathieu Poirier wrote:
> On 20 May 2015 at 09:02, Ivan T. Ivanov ivanov@xxxxxxxxxx> wrote:
> > Add Qualcomm's PFT v1.1 peripheral ID to supported devices.
> > This device could be found at least in MSM8974 and APQ8064
> > chipsets.
> >
> > Signed-off-by: Ivan T. Ivanov ivanov@xxxxxxxxxx>
> > ---
> > drivers/hwtracing/coresight/coresight-etm3x.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/hwtracing/coresight/coresight-etm3x.c
> > b/drivers/hwtracing/coresight/coresight-etm3x.c
> > index 018a00f..e13520f 100644
> > --- a/drivers/hwtracing/coresight/coresight-etm3x.c
> > +++ b/drivers/hwtracing/coresight/coresight-etm3x.c
> > @@ -1912,6 +1912,11 @@ static struct amba_id etm_ids[] = {
> > .mask = 0x0003ffff,
> > .data = "PTM 1.1",
> > },
> > + { /* PFT 1.1 Qualcomm */
> > + .id = 0x0003006f,
> > + .mask = 0x0003ffff,
> > + .data = "PFT 1.1",
> > + },
> > { 0, 0},
> > };
>
> I'm essentially good with that. On the flip side "PFT" is the format
> of the output generated by the tracer. What is important to identify
> is the type of tracer fitted to the SoC, either "ETM" or "PTM".

I was unable to find PTM 1.1 in the ARM documentation and PFT
v1.1 is supported only by PTM, if understand it correctly.

Regards,
Ivan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/