Re: [PATCH 01/10] perf,x86: Fix event/group validation

[Stephane Eranian]

On Thu, May 21, 2015 at 7:53 AM, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> On Thu, May 21, 2015 at 01:17:11PM +0200, Peter Zijlstra wrote:
>> --- a/arch/x86/kernel/cpu/perf_event_intel_ds.c
>> +++ b/arch/x86/kernel/cpu/perf_event_intel_ds.c
>> @@ -706,9 +706,9 @@ void intel_pmu_pebs_disable(struct perf_
>>
>>       cpuc->pebs_enabled &= ~(1ULL << hwc->idx);
>>
>> -     if (event->hw.constraint->flags & PERF_X86_EVENT_PEBS_LDLAT)
>> +     if (event->hw.flags & PERF_X86_EVENT_PEBS_LDLAT)
>>               cpuc->pebs_enabled &= ~(1ULL << (hwc->idx + 32));
>> -     else if (event->hw.constraint->flags & PERF_X86_EVENT_PEBS_ST)
>> +     else if (event->hw.flags & PERF_X86_EVENT_PEBS_ST)
>>               cpuc->pebs_enabled &= ~(1ULL << 63);
>>
>>       if (cpuc->enabled)
>
> This btw look like an independent bug.

You mean, referring to event->hw.constraint?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/