Re: random: Wake up all getrandom(2) callers when pool is ready

[Theodore Ts'o]

On Thu, May 21, 2015 at 04:19:54PM +0800, Herbert Xu wrote:
> On Thu, May 21, 2015 at 09:55:17AM +0200, Stephan Mueller wrote:
> >
> > So, I will create a 2nd wait queue in random.c for uninterruptible waits, 
> > change the get_blocking_random_bytes back to void and use wait_event to wait 
> > for the initialization.
> 
> Hold your horses.  You don't need a second queue, you just need to
> change wake_up_interruptible to wake_up.
> 
> Hmm, in fact shouldn't this be wake_up_all? Otherwise what are the
> other getrandom(2) callers going to do? Ted?

Yes, this should definitely be wake_up_all()

							- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/