RE: [PATCH 12/19] ACPICA: ACPI 6.0: Add changes for MADT table.

[Zheng, Lv]

Hi,

> From: Hanjun Guo [mailto:hanjun.guo@xxxxxxxxxx]
> Sent: Thursday, May 21, 2015 10:36 PM
> 
> Hi Lv,
> 
> On 2015å05æ21æ 10:31, Lv Zheng wrote:
> > From: Bob Moore <robert.moore@xxxxxxxxx>
> >
> > ACPICA commit 02cbb41232bccf7a91967140cab95d5f48291f21
> >
> > New subtable type. Some additions to existing subtables.
> >
> > Link: https://github.com/acpica/acpica/commit/02cbb412
> > Signed-off-by: Bob Moore <robert.moore@xxxxxxxxx>
> > Signed-off-by: Lv Zheng <lv.zheng@xxxxxxxxx>
> > ---
> [...]
> >
> >   /* Masks for Flags field above */
> > @@ -819,7 +822,7 @@ struct acpi_madt_generic_interrupt {
> >   #define ACPI_MADT_PERFORMANCE_IRQ_MODE  (1<<1)	/* 01: Performance Interrupt Mode */
> >   #define ACPI_MADT_VGIC_IRQ_MODE         (1<<2)	/* 02: VGIC Maintenance Interrupt mode */
> >
> > -/* 12: Generic Distributor (ACPI 5.0) */
> > +/* 12: Generic Distributor (ACPI 5.0 + ACPI 6.0 changes) */
> >
> >   struct acpi_madt_generic_distributor {
> >   	struct acpi_subtable_header header;
> > @@ -827,7 +830,8 @@ struct acpi_madt_generic_distributor {
> >   	u32 gic_id;
> >   	u64 base_address;
> >   	u32 global_irq_base;
> > -	u32 reserved2;		/* reserved - must be zero */
> > +	u8 version;
> 
> version filed in generic distributor has following values,
> 
> /* Values for gic_version in Generic Distributor  (ACPI 6.0) */
> 
> enum acpi_madt_gic_ver_type
> {
>          ACPI_MADT_GIC_VER_UNKNOWN       = 0,
>          ACPI_MADT_GIC_VER_V1            = 1,
>          ACPI_MADT_GIC_VER_V2            = 2,
>          ACPI_MADT_GIC_VER_V3            = 3,
>          ACPI_MADT_GIC_VER_V4            = 4,
>          ACPI_MADT_GIC_VER_RESERVED      = 5     /* 5 and greater are
> reserved */
> };
> 
> should we put it here, or locate it to ARM64 arch related head
> file?

Yes, you can put it here.
And also please help to submit an ACPICA patch to <devel@xxxxxxxxxx>.

Thanks and best regards
-Lv


> 
> Thanks
> Hanjun
N‹§²æ¸›yú²X¬¶ÇvØ–)Þ{.nlj·¥Š{±‘êX§¶›¡Ü}©ž²ÆzÚj:+v‰¨¾«‘êZ+€Êzf£¢·hšˆ§~†­†Ûÿû®w¥¢¸?™¨è&¢)ßf”ùy§m…á«a¶Úÿ0¶ìå