Re: [PATCH] livepatch: Let compiler put module initialized function to section ".init.text"
From: Josh Poimboeuf
Date: Fri May 22 2015 - 09:25:37 EST
On Fri, May 22, 2015 at 02:10:32PM +0800, Minfei Huang wrote:
> From: Minfei Huang <mnfhuang@xxxxxxxxx>
>
> Usually we prefer to let compiler put the module initialized function to
> section ".init.text". Thus this text in memory will be freed in future.
>
> Once we add the "__init" preceding function name, we can use following
> command to find it in specfied section.
>
> $ objdump -t -j .init.text built-in.o
>
> built-in.o: file format elf64-x86-64
>
> SYMBOL TABLE:
> 0000000000000000 l d .init.text 0000000000000000 .init.text
> 0000000000000000 l F .init.text 000000000000004e klp_init
>
> Signed-off-by: Minfei Huang <mnfhuang@xxxxxxxxx>
The patch looks good but can you make the subject more concise? Maybe
something like:
livepatch: annotate klp_init() with __init
Thanks.
--
Josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/