Re: [PATCH v2 1/7] clocksource: export "arch_timer_get_rate" for the other drivers

[Guenter Roeck]

On Fri, May 22, 2015 at 09:09:10AM -0500, Timur Tabi wrote:
> fu.wei@xxxxxxxxxx wrote:
> >Some devices get clock from system counter, like SBSA watchdog
> >driver. They may need to get system counter rate.
> 
> We don't need this patch.  The watchdog driver can use
> arch_timer_get_cntfrq() instead of arch_timer_get_rate().  There's nothing
> wrong with arch_timer_get_cntfrq() since the SBSA driver is intended only
> for ARM64 server systems, and arch_timer_get_cntfrq() is always defined for
> such systems.
> 
I agree, since the SBSA driver also uses arch_counter_get_cntvct()
which is declared in the same include file as arch_timer_get_cntfrq().
The additional dependency does not provide any value, unless architecture
implementation dependencies can be removed entirely, which does not seem
to be the case.

Doo bad that SBSA is not hardware independent enough to provide all
the information needed to implement such a driver :-(.

Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/