Re: [RFC v3 PATCH 04/10] mm/hugetlb: expose hugetlb fault mutex for use by fallocate

[Mike Kravetz]

On 05/22/2015 10:01 AM, Davidlohr Bueso wrote:
> On Thu, 2015-05-21 at 08:47 -0700, Mike Kravetz wrote:
> > +/*
> > + * Interfaces to the fault mutex routines for use by hugetlbfs
> > + * fallocate code.  Faults must be synchronized with page adds or
> > + * deletes by fallocate.  fallocate only deals with shared mappings.
> > + */
> > +u32 hugetlb_fault_mutex_shared_hash(struct address_space *mapping, pgoff_t idx)
> > +{
> > +	return fault_mutex_hash(NULL, NULL, NULL, mapping, idx, 0);
> > +}
> > +
> > +void hugetlb_fault_mutex_lock(u32 hash)
> > +{
> > +	mutex_lock(&htlb_fault_mutex_table[hash]);
> > +}
> > +
> > +void hugetlb_fault_mutex_unlock(u32 hash)
> > +{
> > +	mutex_unlock(&htlb_fault_mutex_table[hash]);
> > +}+
>
> These should really be inlined -- maybe add them to hugetlb.h along with
> the mutex hashtable bits.

Thanks.  I'll figure out some way to inline them in the next version
of the patch set.

--
Mike Kravetz

> Thanks,
> Davidlohr
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/