Re: [RFC PATCH v3 08/37] bpf tools: Define basic interface

[Jiri Olsa]

On Mon, May 18, 2015 at 10:57:36AM -0700, Alexei Starovoitov wrote:
> On 5/17/15 3:56 AM, Wang Nan wrote:
> >bpf_open_object() and bpf_close_object() are open and close function of
> >eBPF object files. 'struct bpf_object' will be handler of one object
> >file. Its internal structure is hide to user.
> >
> >Signed-off-by: Wang Nan <wangnan0@xxxxxxxxxx>
> >---
> ...
> >+
> >+struct bpf_object *bpf_open_object(const char *path)
> >+{
> >+	return NULL;
> >+}
> >+
> >+void bpf_close_object(struct bpf_object *object)
> >+{
> >+	return 0;
> >+}
> 
> I'm not a fan of introducing empty helpers. I would
> squash it with the patch that actually adds meat to it.
> 

agreed, also:

[jolsa@krava bpf]$ make
  CC       libbpf.o
libbpf.c: In function âbpf_close_objectâ:
libbpf.c:68:2: warning: âreturnâ with a value, in function returning void [enabled by default]
  return 0;
  ^
  LD       libbpf-in.o
  LINK     libbpf.a
  LINK     libbpf.so


jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/