Re: [PATCH soc] ARM: use ARM_SINGLE_ARMV7M for ARMv7-M platforms

[Russell King - ARM Linux]

On Fri, May 22, 2015 at 05:29:20PM +0200, Maxime Coquelin wrote:
> 2015-05-22 16:50 GMT+02:00 Arnd Bergmann <arnd@xxxxxxxx>:
> > [one small request as I have four armv7-m folks on Cc already:
> >  could one of you try to fix the warning that I get with every
> >  single build: "/git/arm-soc/arch/arm/kernel/head-nommu.S: Assembler
> > messages: /git/arm-soc/arch/arm/kernel/head-nommu.S:167: Warning:
> > Use of r13 as a source register is deprecated when r15 is the
> > destination register."]
> 
> Moving r13 to r12 and returning r12 seems to do the job (see below).
> But I don't know if there is a more elegant way, and if it is also
> valid for other architectures than armv7-m.
> I can propose a patch if someone can confirm it is valid.

Please follow the ARM code example, rather than inventing alternative
solutions to the same problem that was solved there.  We use r3 for
this there:

        mov     r3, r13
        ret     r3

Consistency _is_ important.

Thanks.

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/