Re: [PATCH] tty: remove platform_sysrq_reset_seq

From: Arnd Bergmann
Date: Fri May 22 2015 - 15:59:10 EST


On Thursday 21 May 2015 11:11:28 Arnd Bergmann wrote:
> diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c
> index 8ba52e56bb8b..9c5395db6a57 100644
> --- a/drivers/tty/sysrq.c
> +++ b/drivers/tty/sysrq.c
> @@ -55,8 +55,7 @@
> static int __read_mostly sysrq_enabled = CONFIG_MAGIC_SYSRQ_DEFAULT_ENABLE;
> static bool __read_mostly sysrq_always_enabled;
>
> -unsigned short platform_sysrq_reset_seq[] __weak = { KEY_RESERVED };
> -int sysrq_reset_downtime_ms __weak;
> +static int sysrq_reset_downtime_ms;
>
> static bool sysrq_on(void)
> {
>

It turns out that the variable is now potentially unused, and we get a warning
when CONFIG_INPUT is disabled. I'll send a fixed v2 of this patch.

Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/