Re: [V5 PATCH 1/5] ACPI / scan: Parse _CCA and setup device coherency

[Suravee Suthikulanit]

Not sure if this went out earlier. So I am resending.

On 5/22/15 16:56, Rafael J. Wysocki wrote:
> > diff --git a/drivers/acpi/glue.c b/drivers/acpi/glue.c
> > >index 39c485b..b9657af 100644
> > >--- a/drivers/acpi/glue.c
> > >+++ b/drivers/acpi/glue.c
> > >@@ -13,6 +13,7 @@
> > >  #include <linux/slab.h>
> > >  #include <linux/rwsem.h>
> > >  #include <linux/acpi.h>
> > >+#include <linux/dma-mapping.h>
> > >
> > >  #include "internal.h"
> > >
> > >@@ -167,6 +168,7 @@ int acpi_bind_one(struct device *dev, struct acpi_device *acpi_dev)
> > >  	struct list_head *physnode_list;
> > >  	unsigned int node_id;
> > >  	int retval = -EINVAL;
> > >+	bool coherent;
> > >
> > >  	if (has_acpi_companion(dev)) {
> > >  		if (acpi_dev) {
> > >@@ -223,6 +225,9 @@ int acpi_bind_one(struct device *dev, struct acpi_device *acpi_dev)
> > >  	if (!has_acpi_companion(dev))
> > >  		ACPI_COMPANION_SET(dev, acpi_dev);
> > >
> > >+	if (acpi_check_dma(acpi_dev, &coherent))
> > >+		arch_setup_dma_ops(dev, 0, 0, NULL, coherent);
> > >+
> Well, so is this going to work for PCI too after all?

No, as Bjorn suggested, PCI changes for setting DMA coherent from _CCA 
(patch 3/6 in V4) will be submitted separately. We are working on 
cleaning up and up-streaming the PCI ACPI support for ARM64.

Thanks,

Suravee

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/