Re: [PATCH v3 2/3] dell-rbtn: Export notifier for other kernel modules

From: Dmitry Torokhov
Date: Fri May 22 2015 - 18:46:04 EST


On Thu, May 14, 2015 at 3:54 AM, Pali RohÃr <pali.rohar@xxxxxxxxx> wrote:

> @@ -328,7 +408,9 @@ static void rbtn_notify(struct acpi_device *device, u32 event)
>
> static int __init rbtn_init(void)
> {
> - return acpi_bus_register_driver(&rbtn_driver);
> + /* ignore errors so module always loads and exports needed functions */
> + acpi_bus_register_driver(&rbtn_driver);
> + return 0;

Ahem, and if it fails for some reason and you try to unload the module
what will happen when you call
acpi_bus_unregister_driver(&rbtn_driver) in rbtn_exit()?\

Thanks.

--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/