Re: [PATCH 1/1] drivers: staging: unisys: visorbus: visorchipset.c: private functions should be declared static

[tolga ceylan]

On 05/15/2015 09:22 PM, Tolga Ceylan wrote:
> visorchipset_file_init() and visorchipset_file_cleanup() functions
> do not seem to be used from anywhere else and now are declared
> as static. Sparse emitted "not declared" warnings for these two
> functions.
>
> Signed-off-by: Tolga Ceylan <tolga.ceylan@xxxxxxxxx>
> ---
>   drivers/staging/unisys/visorbus/visorchipset.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c
> index ca22f49..66ae3d0 100644
> --- a/drivers/staging/unisys/visorbus/visorchipset.c
> +++ b/drivers/staging/unisys/visorbus/visorchipset.c
> @@ -2351,7 +2351,7 @@ static const struct file_operations visorchipset_fops = {
>   	.mmap = visorchipset_mmap,
>   };
>
> -int
> +static int
>   visorchipset_file_init(dev_t major_dev, struct visorchannel **controlvm_channel)
>   {
>   	int rc = 0;
> @@ -2460,7 +2460,7 @@ cleanup:
>   	return rc;
>   }
>
> -void
> +static void
>   visorchipset_file_cleanup(dev_t major_dev)
>   {
>   	if (file_cdev.ops)

I haven't received a response for this patch. Just checking back.

Regards,
Tolga Ceylan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/