Re: [PATCH v2 6/7] Watchdog: introduce ARM SBSA watchdog driver

From: Guenter Roeck
Date: Sun May 24 2015 - 13:33:04 EST


On 05/24/2015 10:19 AM, Timur Tabi wrote:
Fu Wei wrote:
I don't know why you want to do this tricky way. you can always
register the interrupt handler,
if pre-timeout is 0, system will just trigger WS1 right after WS0

But that only works if the pre-timeout and timeout can be programmed to separate values. And as Guenter says, the SBSA may not guarantee that.


The pseudo-code in the specification suggests that if WCV is configured,
WS0 = WCV
WS1 = WCV + WOR

Assuming that the implementation follows the pseudo-code in the specification,
we would have separately programmable values. Since the pretimeout (per ABI)
is the difference in seconds to the timeout, and not an absolute value,
we would have to program the registers as follows.

WCV = timeout - pretimeout;
WOR = pretimeout;

Does this make sense ?

Thanks,
Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/