Re: [char-misc-next 11/11] mei: revamp mei bus code

[Greg KH]

On Thu, May 07, 2015 at 03:54:08PM +0300, Tomas Winkler wrote:
> MEI bus was designed around nfc and was hard to extend.
> Instead of hard coded way of adding the devices on the mei bus
> we scan whole me client list and create a device for each
> eligible me client; currently we support only clients with
> single connection and fixed address clients.
> NFC radio name detection is run as a fixup routine
> 
> Cc: Samuel Ortiz <sameo@xxxxxxxxxxxxxxx>
> Signed-off-by: Tomas Winkler <tomas.winkler@xxxxxxxxx>
> ---
>  drivers/misc/mei/Makefile    |   2 +-
>  drivers/misc/mei/bus-fixup.c | 306 ++++++++++++++
>  drivers/misc/mei/bus.c       | 975 ++++++++++++++++++++++++++++---------------
>  drivers/misc/mei/client.c    |   9 +-
>  drivers/misc/mei/init.c      |   5 +-
>  drivers/misc/mei/mei_dev.h   |  24 +-
>  drivers/misc/mei/nfc.c       | 414 ------------------
>  include/linux/mei_cl_bus.h   |  12 +
>  8 files changed, 968 insertions(+), 779 deletions(-)
>  create mode 100644 drivers/misc/mei/bus-fixup.c
>  delete mode 100644 drivers/misc/mei/nfc.c

This is a lot to do in just one patch.  Any chance you can split it up
into reviewable pieces?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/