Re: [PATCH 1/1] dmaengine: pl330: Initialize pl330 for pl330_prep_dma_memcpy after NULL check of pch

[Vinod Koul]

On Sun, May 24, 2015 at 06:30:36PM +0530, Maninder Singh wrote:
> git send-email missed one line
> Add it in description too
> 
> On 24 May 2015 18:11, "Maninder Singh" <shanky.cool1992@xxxxxxxxx> wrote:
> >
> > From: Maninder Singh <maninder1.s@xxxxxxxxxxx>
> >
> 
> Currently pch pointer is already dereferenced before NULL check
> And thus we are getting below warning:
> Warn: variable dereferenced before check 'pch'
no you resend the patch with this description and this is something we need
here

-- 
~Vinod

> 
> > So initialize struct pl330_dmac *pl330 after NULL check
> > of dma_pl330_chan *pch.
> >
> > Signed-off-by: Maninder Singh <maninder1.s@xxxxxxxxxxx>
> > Reviewed-by: Vaneet Narang <v.narang@xxxxxxxxxxx>
> > ---
> >  drivers/dma/pl330.c |    4 +++-
> >  1 files changed, 3 insertions(+), 1 deletions(-)
> > diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
> > index a7d9d30..7e27144 100644
> > --- a/drivers/dma/pl330.c
> > +++ b/drivers/dma/pl330.c
> > @@ -2581,12 +2581,14 @@ pl330_prep_dma_memcpy(struct dma_chan *chan,
> dma_addr_t dst,
> >  {
> >         struct dma_pl330_desc *desc;
> >         struct dma_pl330_chan *pch = to_pchan(chan);
> > -       struct pl330_dmac *pl330 = pch->dmac;
> > +       struct pl330_dmac *pl330;
> >         int burst;
> >
> >         if (unlikely(!pch || !len))
> >                 return NULL;
> >
> > +       pl330 = pch->dmac;
> > +
> >         desc = __pl330_prep_dma_memcpy(pch, dst, src, len);
> >         if (!desc)
> >                 return NULL;
> > --
> > 1.7.1

-- 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/