Re: [PATCH] perf: fix wrong DEBUG configuration

From: Ingo Molnar
Date: Mon May 25 2015 - 14:32:57 EST



* Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> wrote:

> Em Mon, May 25, 2015 at 01:12:44PM +0200, Martin LiÅka escreveu:
> > On 05/25/2015 01:09 PM, Ingo Molnar wrote:
> > >
> > >* Martin LiÅka <mliska@xxxxxxx> wrote:
> > >
> > >>>>Right optimize debugging experience is given by passing -Og to
> > >>>>compiler. Assign default value for pointers that are identified by
> > >>>>compiler as non-initialized.
> > >>>
> > >>>s/Right optimize debugging experience is given/
> > >>> Correct debugging experience is given/
> > >
> > >>Right debugging experience is given by passing -Og to compiler.
> > >
> > >So I fixed the spelling here once already :-/ If you want to use
> > >'right' in this context then use it like this:
> > >
> > > The right debugging experience is given by ...
> > >
> > >Or you can use what I suggested first:
> > >
> > > Correct debugging experience is given by ...
> > >
> > >Thanks,
> > >
> > > Ingo
> > >
> >
> > Sorry Ingo for that, I overlooked that correction :)
>
> Are you ok with this Ingo?

Yeah, certainly!

> I can apply, but there seems to be two patches folded here, one that
> sets the possibly unitiliazed variables to NULL, and could be the
> first in the series, and the other, that deals with multiple
> versions of gcc and how should we ask something from them.

Yeah.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/