Re: [PATCH net-next v5 2/2] net: Adding support for Cavium ThunderX network controller

[David Miller]

From: Aleksey Makarov <aleksey.makarov@xxxxxxxxxxxxxxxxxx>
Date: Fri, 22 May 2015 18:28:16 -0700

> +#ifdef NOT_SUPPORTED_FOR_NOW
> +static int nicvf_set_coalesce(struct net_device *netdev,
> +			      struct ethtool_coalesce *cmd)
> +{
 ...
> +#ifdef NOT_SUPPORTED_FOR_NOW
> +	.set_coalesce		= nicvf_set_coalesce,
> +#endif
> +	.get_ringparam		= nicvf_get_ringparam,

Remove this completely.  When you actually make it work and want to
enable it, you can re-add the code.

The upstream kernel is not your personal workspace :-)

> +#ifdef VNIC_RSS_SUPPORT

This is unconditionally defined in one of your headers, please remove
these ifdefs as they will never be false.

> +#ifdef VNIC_RSS_SUPPORT

Likewise.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/