Re: [PATCH 1/5] usb: xhci: cleanup xhci_hcd allocation

[Andrew Bresticker]

Hi Mathias,

On Mon, May 25, 2015 at 8:05 AM, Mathias Nyman
<mathias.nyman@xxxxxxxxxxxxxxx> wrote:
>>>>>
>>>>> I've been testing add/remove HCD extensively and didn't observe any issues after applying
>>>>> these 5 patches. Well there is one issue that comes up but it has nothing to do with xhci
>>>>> not being allocated. It has more to do with command being queued after the HCD has gone away
>>>>> and so getting stuck forever without timing out.
>>>>
>>>> I went through the codepaths and you're right, should work fine. My concern wasn't valid.
>>>> This patchset doesn't even touch the order how primary and shared HCDs are created and added
>>>> in the PCI case, only for the platform device case.
>>>>
>>>> I'll try it out and send forward once rc1 is out.
>>>
>>> did you get a chance to try this series?
>>>
>>
>> Sorry, not yet, got delayed by other internal tasks.
>> I'll try it out as soon as possible.
>>
>>
>
> Ok, back to this, I'd like to get both this series and Andrew's xhci-tegra
> support to 4.2
>
> I did similar changes to xhci-tegra.c as Roger did to xhci-pci.c and xhci-plat.c,
> but I can't test them and would need both your eyes on this to make sure it looks ok.
>
> Both series are in a tegra_otg_merge topic branch in:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/mnyman/xhci.git tegra_otg_merge
>
> It contains Andrews full xhci tegra support series, but If I understood correctly only
> patch 9/9 (maybe 8/9 as well?) will actually go through the xhci tree.
> Patch 1/9 is not needed with Roger's changes anymre
>
> The changes are in the last patch, here:
> https://git.kernel.org/cgit/linux/kernel/git/mnyman/xhci.git/commit/?h=tegra_otg_merge
>
> and would be squashed together with patch 9/9.

No need to apply patch 8/9 or 9/9... Lee Jones has NAK'ed the MFD
driver on which the xhci-tegra driver depends, so I'll need to re-spin
the series.  It would be great if you could ACK those two patches
though so that the entire series could go through the Tegra tree for
4.3.

Thanks,
Andrew
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/