Re: [PATCH 04/10] perf, tools, report: Add processing for cycle histograms

From: Andi Kleen
Date: Tue May 26 2015 - 13:37:41 EST


> hum, so this is assuming that having cycles fort 1st entry
> means there'll be for the rest?
> Also in that case why is there the '!= cycles' check within
> addr_map_symbol__account_cycles ?
>
It means there might be. It's just a short cut. But rarely
branches may still have 0 cycles, so it still needs to be
checked later.

In theory it could miss a valid one if the first happened
to be zero, but that seems very unlikely.


-Andi

--
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/