Re: [PATCH] livepatch: match return value to function signature

[Nicholas Mc Guire]

On Mon, 11 May 2015, Jiri Slaby wrote:

> On 05/11/2015, 07:52 AM, Nicholas Mc Guire wrote:
> > klp_initialized() should return bool but is actually returning 
> > struct kobject * - convert it to a boolean explicitly.
> > 
> > Signed-off-by: Nicholas Mc Guire <hofrat@xxxxxxxxx>
> 
> Reviewed-by: Jiri Slaby <jslaby@xxxxxxx>
>
sorry for the noise - discussions about a similar "cleanup" in RCU
resulted Joe Perches <joe@xxxxxxxxxxx> clarifying the matter - this
explicit conversion makes static code checkers happy but is not
needed for gcc (or C for that mater) - see 
  http://lkml.org/lkml/2015/5/24/47
  and ISO/IEC 9899:1999 (c99) 6.8.6.4 subclause 3)

thx!
hofrat
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/