RE: [PATCH v2 0/2] Drivers: hv: vmbus: use cpu_hotplug_enable/disable for CPU offlining prevention

From: KY Srinivasan
Date: Wed May 27 2015 - 12:26:19 EST




> -----Original Message-----
> From: Greg KH [mailto:gregkh@xxxxxxxxxxxxxxxxxxx]
> Sent: Wednesday, May 27, 2015 8:06 AM
> To: KY Srinivasan
> Cc: Vitaly Kuznetsov; Radim KrÄmÃÅ; Peter Zijlstra; Haiyang Zhang; Rafael J.
> Wysocki; linux-kernel@xxxxxxxxxxxxxxx; devel@xxxxxxxxxxxxxxxxxxxxxx;
> Thomas Gleixner; Paul E. McKenney; Ingo Molnar
> Subject: Re: [PATCH v2 0/2] Drivers: hv: vmbus: use
> cpu_hotplug_enable/disable for CPU offlining prevention
>
> On Wed, May 27, 2015 at 02:37:14PM +0000, KY Srinivasan wrote:
> >
> >
> > > -----Original Message-----
> > > From: Vitaly Kuznetsov [mailto:vkuznets@xxxxxxxxxx]
> > > Sent: Wednesday, May 27, 2015 2:15 AM
> > > To: KY Srinivasan
> > > Cc: devel@xxxxxxxxxxxxxxxxxxxxxx; Haiyang Zhang; linux-
> > > kernel@xxxxxxxxxxxxxxx; Dexuan Cui; Ingo Molnar; Paul E. McKenney;
> Rafael
> > > J. Wysocki; Peter Zijlstra; Thomas Gleixner; Radim KrÄmÃÅ
> > > Subject: Re: [PATCH v2 0/2] Drivers: hv: vmbus: use
> > > cpu_hotplug_enable/disable for CPU offlining prevention
> > >
> > > KY Srinivasan <kys@xxxxxxxxxxxxx> writes:
> > >
> > > >> -----Original Message-----
> > > >> From: Vitaly Kuznetsov [mailto:vkuznets@xxxxxxxxxx]
> > > >> Sent: Thursday, May 21, 2015 9:22 AM
> > > >> To: devel@xxxxxxxxxxxxxxxxxxxxxx
> > > >> Cc: KY Srinivasan; Haiyang Zhang; linux-kernel@xxxxxxxxxxxxxxx;
> Dexuan
> > > Cui;
> > > >> Ingo Molnar; Paul E. McKenney; Rafael J. Wysocki; Peter Zijlstra;
> Thomas
> > > >> Gleixner; Radim KrÄmÃÅ
> > > >> Subject: [PATCH v2 0/2] Drivers: hv: vmbus: use
> > > cpu_hotplug_enable/disable
> > > >> for CPU offlining prevention
> > > >>
> > > >> Changes since v1:
> > > >> - Make cpu_hotplug_disabled a counter [Radim KrÄmÃÅ]
> > > >>
> > > >> Export cpu_hotplug_enable/cpu_hotplug_disable functions from
> cpu.c
> > > and
> > > >> use
> > > >> them instead of altering smp_ops.cpu_disable in Hyper-V vmbus
> module.
> > > >>
> > > >> Vitaly Kuznetsov (2):
> > > >> cpu-hotplug: export cpu_hotplug_enable/cpu_hotplug_disable
> > > >> Drivers: hv: vmbus: use cpu_hotplug_enable/disable
> > > >
> > > > Vitaly,
> > > >
> > > > Since there is a cross tree dependency here, could you resubmit the
> vmbus
> > > patch
> > > > after the CPU hotplug patch has been committed.
> > >
> > > I'm afraid it won't be committed without the second patch as without a
> > > single user of cpu_hotplug_enable/cpu_hotplug_disable (among
> modules)
> > > this patch doesn't make much sense. I would rather expect both of them
> > > to go through Greg's tree but with proper sign-offs/reviewed-bys. And
> > > of course this decision is up to tree maintainers, I'll resubmit the
> > > vmbus patch in case CPU hotplug patch gets committed separately.
> >
> > I had asked if Greg could take both the patches and I have not heard from
> him yet and I
> > assumed that he would not.
>
> Don't you love it when people ask you to do things, yet never even cc:
> you on an email and still expect you to magically notice and respond to
> them?

Greg,

When I send patches, you are always on the "to" list and I was just responding to Vitaly's email
(assuming that you were on the "to" list - my bad). Sorry about that.
>
> {sigh}
>
> You got lucky here, I happened to notice this email, but I have no email
> from you to me where you asked me to do anything.
>
> As I told you before, you need to repackage up patches you want to have
> applied and send them to me, that's the job of a subsystem maintainer,
> you can't just "expect" someone else to magically notice them and apply
> them for you.

The issue is not one of packaging. Vitaly has two patches in this series each of which
needs to go through a different tree. I wanted to know if you can take both patches
through your tree. In any case, I will repackage and send them to you.

Thank you,

K. Y
>
> greg k-h