Re: [PATCH] core: Convert the function process_ipcsec to the, return type bool

[Joe Perches]

On Wed, 2015-05-27 at 21:14 -0400, Nicholas Krause wrote:
> This makes the function,process_ipsec have a return true
> of bool now due to only returning 1 or 0. In additon this
> changes this function's return statements to return true
> and false rather then 1 and 0 respectfully.

The patch subject title and the grammar in the commit message
could be improved, but other than that, it seems OK to me.

I would have written something like:

Subject: [PATCH] pktgen: Convert return type of process_ipsec to bool

It's used as a bool function, make it so.
Convert the return 1/0 to return true/false too.

Signed-off-by: etc...


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/