Hi,Your comment to the first patch. But I interpreted it to broadly.
On 27/05/2015 at 14:48:16 +0200, Jan Kardell wrote :
@@ -204,6 +204,7 @@ static int pcf8563_get_datetime(struct i2c_client *client, struct rtc_time *tm)Aren't dev_err or dev_warn more appropriate? You used dev_err in your
pcf8563->voltage_low = 1;
dev_info(&client->dev,
first patch, what made you change your mind?
"low voltage detected, date/time is not reliable.\n");
+ return -EINVAL;
}
dev_dbg(&client->dev,