Re: [PATCH] staging: gdm72xx: remove unneeded test

[Dan Carpenter]

Obviously, I endorse this idea.  :)  Every out label in this file is
a do-nothing label or a do-everything label, but with bugs.  usb_boot()
should look like:

free_tx_buf:
	kfree(tx_buf);
release_firm:
	release_firmware(firm);

	ret;

If we fail to allocate "tx_buf" then we should release the firmware.
em_download_image() has the same bug as well.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/