Re: [PATCH 1/5] init/Kconfig: Fix break in middle of EXPERT menu

[Paul Bolle]

On Thu, 2015-05-14 at 08:35 -0700, Josh Triplett wrote:
> Commit e1abf2cc8d5 ("bpf: Fix the build on BPF_SYSCALL=y &&
> !CONFIG_TRACING kernels, make it more configurable") made BPF_SYSCALL no
> longer hidden with !EXPERT, but left it in the middle of the EXPERT
> menu.  menuconfig stops putting config items under a submenu once it
> encounters an item that doesn't depend on the menu's config item, so

s/that/whose visibility/?

As far as I can see what suffices for menuconfig is that the visibility
of an item is influenced by that menu's symbol. Whether that item is
actually not set at all (the depends on case) or only not visible (the
"prompt" if EXPERT case) doesn't matter here.

> this caused the remainder of the EXPERT menu to spill out into the
> containing menu around it.  Fix by moving BPF_SYSCALL before the EXPERT
> menu, next to BPF.
> 
> Fixes: e1abf2cc8d5 ("bpf: Fix the build on BPF_SYSCALL=y && !CONFIG_TRACING kernels, make it more configurable")
> Signed-off-by: Josh Triplett <josh@xxxxxxxxxxxxxxxx>

Provided you somehow tweak the commit explanation to reflect my remark:
    Acked-by: Paul Bolle <pebolle@xxxxxxxxxx>

>  init/Kconfig | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)

Who's in charge of init/Kconfig?

Thanks,


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/