Re: [PATCH 1/1] x86_64: fix KASan shadow region page tables

From: Alexander Popov
Date: Thu May 28 2015 - 04:56:20 EST


On 26.05.2015 11:52, Andrey Ryabinin wrote:
> On 05/25/2015 04:43 PM, Alexander Popov wrote:
>> What do you think about leaving the initialization of KASan shadow region
>> page tables in arch/x86/kernel/head_64.S and calling something like
>> kasan_fixup_early_shadow() before calling kasan_map_early_shadow()
>> for the first time?
>
> Why do we have initialize + fixup later if we could simply initialize page tables properly?
>
> Just move everything into kasan_init_64.c
> kasan_zero_p* could be a normal C arrays (with __page_aligned_bss attribute).
> Initialize these page tables in something like kasan_early_init() before kasan_map_early_shadow()
> call.

Thanks, I'll do that and return with the second version.

Best regards,
Alexander

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/