Re: [PATCH] staging: gdm72xx: remove unneeded test

[Julia Lawall]

On Wed, 27 May 2015, Joe Perches wrote:

> On Thu, 2015-05-28 at 07:43 +0200, Julia Lawall wrote:
> > On Wed, 27 May 2015, Joe Perches wrote:
> > > Perhaps all of the uses like:
> > >
> > > 	goto <foo>;
> > > <foo>:
> > >
> > > could be modified.  There are ~150 in the kernel.
> >
> > I wrote a semantic patch recently for that as well...  Maybe I can take
> > care of it.
>
> Great.  Thanks Julia.
>
> There may be some reorganization of code that is
> possible for many of these than coccinelle may
> not perform well though.

As what looks like an extreme example, wouldn't this function be better as
just return inet6_register_protosw(&rawv6_protosw); ?

int __init rawv6_init(void)
{
        int ret;

        ret = inet6_register_protosw(&rawv6_protosw);
        if (ret)
                goto out;
out:
        return ret;
}

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/