Re: [PATCH] staging: ft1000: warning removal: extern functions to static ones

From: Greg KH
Date: Thu May 28 2015 - 12:26:18 EST


On Thu, May 28, 2015 at 05:24:56PM +0200, Xavier Roche wrote:
> Local functions not used in other modules should be static, not extern.
> (patch checked against linux-next and staging)

This line shouldn't be here, it should just be "implied" :)

> Signed-off-by: Xavier Roche <roche@xxxxxxxxxxx>
> ---
> drivers/staging/ft1000/ft1000-pcmcia/ft1000_dnld.c | 24 +++++++++++-----------
> 1 file changed, 12 insertions(+), 12 deletions(-)

In the future, always use scripts/get_maintainer.pl to determine who to
send patches to please.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/