Re: [PATCH] Revert "PCI/PM: Remove pci_pm_complete()"

[Rafael J. Wysocki]

On Thu, May 28, 2015 at 4:12 AM, Rafael J. Wysocki <rjw@xxxxxxxxxxxxx> wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
>
> Revert commit 84822b158fd3 "PCI/PM: Remove pci_pm_complete()" that
> removed the execution of the device driver's ->complete callback
> from the PCI bus type.
>
> That was a mistake, because those callbacks are not executed at all
> now even if present.
>
> Fixes: 84822b158fd3 "PCI/PM: Remove pci_pm_complete()"
> Cc: 3.13+ <stable@xxxxxxxxxxxxxxx> # 3.13+
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>

Scratch this, sorry.

The code is correct as is, because the bus type doesn't provide
->complete at all in which case the core will run the driver's
callback directly.

We'll probably need ->complete for PCI at one point, but then I'll
resubmit this one with a different changelog.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/