Re: [RFC v3 42/45] nfs: Add richacl support

[Andreas GrÃnbacher]

2015-05-29 1:06 GMT+02:00 Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx>:
> On Fri, Apr 24, 2015 at 7:04 AM, Andreas Gruenbacher
> <andreas.gruenbacher@xxxxxxxxx> wrote:
>> Changes nfs to support the "system.richacl" xattr instead of "system.nfs4_acl".
>>
>
> NACK.
>
> You may declare a userspace syscall ABI that is more than 10 years old
> to be deprecated, but you are not allowed to remove it.

Okay, we can have "system.nfs4_acl" as well, it's just extra code.

> Furthermore, your entire premise of using the mode bits and the acl at
> the same time is flawed; you are at best trying to set up a private
> protocol to pass your mask info. According to RFC7530, Section
> 6.4.1.3, if you try to send the mode bits and ACL in the same SETATTR,
> then the result should be to apply the mode first, then override all
> the lower mode bits (i.e. everything except the suid, sgid and ) with
> the ACL...

What do you mean? I'm happy with the behavior described in Section
6.4.1.3 of RFC 7530; I'm not using the mode bits and the acl at the same
time. What makes you think otherwise?

Thanks,
Andreas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/