Re: [PATCH] fixup! dmaengine: pxa_dma: add debug information

[robert . jarzmik]

----- Mail original -----
De: "Vinod Koul" <vinod.koul@xxxxxxxxx>
Ã: "Robert Jarzmik" <robert.jarzmik@xxxxxxx>

On Wed, May 27, 2015 at 11:23:40PM +0200, Robert Jarzmik wrote:
> This fixes the following error:
> drivers/dma/pxa_dma.c: In function âdbg_show_requester_chanâ:
> drivers/dma/pxa_dma.c:192:2: error: void value not ignored as it ought to be
>   pos += seq_printf(s, "DMA channel %d requester :\n", phy->idx);
> Applied now.
Thanks.

> but not pleased that you sent broken code. Sending stuff that
> compiles is basic step
You should know me better by now. I told you I compiled *and* tested.

And with a a bit closer look check this commit, especially the date :
commit 0bac33653b06a5f80a5c04e275eb33db9493b85a
Author: Joe Perches <joe@xxxxxxxxxxx>
Date:   Sat May 23 12:00:38 2015 +1000

    fs/seq_file: convert int seq_vprint/seq_printf/etc... returns to void

Cheers.

--
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/